Repository: incubator-impala Updated Branches: refs/heads/master 924ddc6e9 -> 491154c8e
IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts Fixes the HS2 timeouts for _all_ Kudu EE tests. Previously only 2 classes had the timeout set, but all the Kudu tests appear to be susceptible to this issue. Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f Reviewed-on: http://gerrit.cloudera.org:8080/6616 Reviewed-by: Michael Brown <[email protected]> Reviewed-by: Alex Behm <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/532c5f26 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/532c5f26 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/532c5f26 Branch: refs/heads/master Commit: 532c5f26052070cccf90eac83de9ba0052879729 Parents: 924ddc6 Author: Matthew Jacobs <[email protected]> Authored: Wed Apr 12 16:42:33 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Thu Apr 13 09:06:50 2017 +0000 ---------------------------------------------------------------------- tests/common/kudu_test_suite.py | 5 +++++ tests/query_test/test_kudu.py | 10 ---------- 2 files changed, 5 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/532c5f26/tests/common/kudu_test_suite.py ---------------------------------------------------------------------- diff --git a/tests/common/kudu_test_suite.py b/tests/common/kudu_test_suite.py index 3e438d0..05d595e 100644 --- a/tests/common/kudu_test_suite.py +++ b/tests/common/kudu_test_suite.py @@ -45,6 +45,11 @@ class KuduTestSuite(ImpalaTestSuite): __DB_NAME = None @classmethod + def get_conn_timeout(cls): + # For IMPALA-5079,IMPALA-4454 + return 60 * 5 # 5 minutes + + @classmethod def setup_class(cls): if os.environ["KUDU_IS_SUPPORTED"] == "false": pytest.skip("Kudu is not supported") http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/532c5f26/tests/query_test/test_kudu.py ---------------------------------------------------------------------- diff --git a/tests/query_test/test_kudu.py b/tests/query_test/test_kudu.py index 8a210a8..86a6fa7 100644 --- a/tests/query_test/test_kudu.py +++ b/tests/query_test/test_kudu.py @@ -45,11 +45,6 @@ class TestKuduOperations(KuduTestSuite): This suite tests the different modification operations when using a kudu table. """ - @classmethod - def get_conn_timeout(cls): - # For IMPALA-5079 - return 60 * 5 # 5 minutes - def test_kudu_scan_node(self, vector, unique_database): self.run_test_case('QueryTest/kudu-scan-node', vector, use_db=unique_database) @@ -512,11 +507,6 @@ class TestCreateExternalTable(KuduTestSuite): class TestShowCreateTable(KuduTestSuite): - @classmethod - def get_conn_timeout(cls): - # For IMPALA-4454 - return 60 * 5 # 5 minutes - def assert_show_create_equals(self, cursor, create_sql, show_create_sql): """Executes 'create_sql' to create a table, then runs "SHOW CREATE TABLE" and checks that the output is the same as 'show_create_sql'. 'create_sql' and
