IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo Impala-lzo contained a buffer overrun that was only present when compiled in optimized mode. To avoid this (IMPALA-5172), Impala-lzo is only compiled in DEBUG mode. Since the underlying buffer overrun has been resolved, reenable passing the CMAKE_BUILD_TYPE down to Impala-lzo.
Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561 Reviewed-on: http://gerrit.cloudera.org:8080/6751 Reviewed-by: Alex Behm <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/ff5b0469 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/ff5b0469 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/ff5b0469 Branch: refs/heads/master Commit: ff5b0469b1a718d8e84976c9946752cfce0e357f Parents: 9efed59 Author: Joe McDonnell <[email protected]> Authored: Thu Apr 27 14:20:07 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Tue May 9 22:18:11 2017 +0000 ---------------------------------------------------------------------- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/ff5b0469/CMakeLists.txt ---------------------------------------------------------------------- diff --git a/CMakeLists.txt b/CMakeLists.txt index 3fa8456..5e568aa 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -387,7 +387,7 @@ add_custom_target(cscope ALL if (DEFINED ENV{IMPALA_LZO} AND EXISTS $ENV{IMPALA_LZO}) add_custom_target(impala-lzo ALL DEPENDS thrift-deps - COMMAND $ENV{IMPALA_LZO}/build.sh DEBUG ${CMAKE_SOURCE_DIR} + COMMAND $ENV{IMPALA_LZO}/build.sh ${CMAKE_BUILD_TYPE} ${CMAKE_SOURCE_DIR} $ENV{IMPALA_TOOLCHAIN} ) endif()
