IMPALA-5391: remove C++11 from UDF header This replaces the C++11 idiom with equivalent C++98 code. The code was added to address a clang-tidy warning about missing virtual destructors, which the new code should also address.
Change-Id: Ic10906027e3644e4d42ad20fcd6abda1c24fefa6 Reviewed-on: http://gerrit.cloudera.org:8080/7024 Reviewed-by: Henry Robinson <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/9caf2142 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/9caf2142 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/9caf2142 Branch: refs/heads/master Commit: 9caf21426bf35fdb380d66c62e279d289df2783d Parents: 4e56cad Author: Tim Armstrong <[email protected]> Authored: Tue May 30 17:29:36 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Wed May 31 07:04:14 2017 +0000 ---------------------------------------------------------------------- be/src/udf/uda-test-harness.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/9caf2142/be/src/udf/uda-test-harness.h ---------------------------------------------------------------------- diff --git a/be/src/udf/uda-test-harness.h b/be/src/udf/uda-test-harness.h index 75ef9b0..cb33ef9 100644 --- a/be/src/udf/uda-test-harness.h +++ b/be/src/udf/uda-test-harness.h @@ -44,7 +44,7 @@ enum UdaExecutionMode { template<typename RESULT, typename INTERMEDIATE> class UdaTestHarnessBase { public: - virtual ~UdaTestHarnessBase() = default; + virtual ~UdaTestHarnessBase() {} typedef void (*InitFn)(FunctionContext* context, INTERMEDIATE* result); @@ -147,7 +147,7 @@ class UdaTestHarnessBase { template<typename RESULT, typename INTERMEDIATE, typename INPUT> class UdaTestHarness : public UdaTestHarnessBase<RESULT, INTERMEDIATE> { public: - virtual ~UdaTestHarness() = default; + virtual ~UdaTestHarness() {} typedef void (*UpdateFn)(FunctionContext* context, const INPUT& input, INTERMEDIATE* result);
