Repository: incubator-impala Updated Branches: refs/heads/master ecda49f3e -> a2281508f
IMPALA-5432: Remove invalid DCHECK from SetMemLimitExceeded - SetMemLimitExeeded conditionally sets query_status to MEM_LIMIT_EXCEEDED if the current query_status is Ok. - The DCHECK in SetMemLimitExceed unconditionally checked if the query_status is set to MEM_LIMIT_EXCEEDED. - It is possible that the query_status was set by some previous error that isn't a MEM_LIMIT_EXCEEDED error. Change-Id: I1c03048ad15739baf7e68ca8d50930f3c45e71c5 Reviewed-on: http://gerrit.cloudera.org:8080/7075 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/a2281508 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/a2281508 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/a2281508 Branch: refs/heads/master Commit: a2281508ff64b9ef3ea730cfd98f6a1c7a497766 Parents: ecda49f Author: John Sherman <[email protected]> Authored: Sun Jun 4 22:49:01 2017 +0000 Committer: Impala Public Jenkins <[email protected]> Committed: Mon Jun 5 17:35:16 2017 +0000 ---------------------------------------------------------------------- be/src/runtime/runtime-state.cc | 1 - 1 file changed, 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/a2281508/be/src/runtime/runtime-state.cc ---------------------------------------------------------------------- diff --git a/be/src/runtime/runtime-state.cc b/be/src/runtime/runtime-state.cc index f632b23..eb11072 100644 --- a/be/src/runtime/runtime-state.cc +++ b/be/src/runtime/runtime-state.cc @@ -237,7 +237,6 @@ void RuntimeState::SetMemLimitExceeded(MemTracker* tracker, LogError(ErrorMsg(TErrorCode::GENERAL, GetTablesMissingStatsWarning(query_ctx().tables_missing_stats))); } - DCHECK(query_status_.IsMemLimitExceeded()); } Status RuntimeState::CheckQueryState() {
