Repository: incubator-impala Updated Branches: refs/heads/master 1d8ad2938 -> e0f69ca1d
IMPALA-5480: Improve missing filters message Replace: "Only following filters arrived: , waited 20ms" with: "Not all filters arrived (arrived: [], missing: [0]), waited 20ms" This shows up in the logs and the profile. Change-Id: Ia87fabdfb591f33343020c4f3bb17dc0fb011046 Testing: ran manually and read the message. Reviewed-on: http://gerrit.cloudera.org:8080/7142 Reviewed-by: Alex Behm <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/fa174fc9 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/fa174fc9 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/fa174fc9 Branch: refs/heads/master Commit: fa174fc962c174598ee41e558aff33698753d9f5 Parents: 1d8ad29 Author: Henry Robinson <[email protected]> Authored: Fri Jun 9 13:41:41 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Sat Jun 10 01:55:01 2017 +0000 ---------------------------------------------------------------------- be/src/exec/hdfs-scan-node-base.cc | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/fa174fc9/be/src/exec/hdfs-scan-node-base.cc ---------------------------------------------------------------------- diff --git a/be/src/exec/hdfs-scan-node-base.cc b/be/src/exec/hdfs-scan-node-base.cc index 89fc469..0e7c319 100644 --- a/be/src/exec/hdfs-scan-node-base.cc +++ b/be/src/exec/hdfs-scan-node-base.cc @@ -550,10 +550,14 @@ bool HdfsScanNodeBase::FilePassesFilterPredicates(const vector<FilterContext>& f bool HdfsScanNodeBase::WaitForRuntimeFilters(int32_t time_ms) { vector<string> arrived_filter_ids; + vector<string> missing_filter_ids; int32_t start = MonotonicMillis(); for (auto& ctx: filter_ctxs_) { + string filter_id = Substitute("$0", ctx.filter->id()); if (ctx.filter->WaitForArrival(time_ms)) { - arrived_filter_ids.push_back(Substitute("$0", ctx.filter->id())); + arrived_filter_ids.push_back(filter_id); + } else { + missing_filter_ids.push_back(filter_id); } } int32_t end = MonotonicMillis(); @@ -566,8 +570,9 @@ bool HdfsScanNodeBase::WaitForRuntimeFilters(int32_t time_ms) { return true; } - const string& filter_str = Substitute("Only following filters arrived: $0, waited $1", - join(arrived_filter_ids, ", "), wait_time); + const string& filter_str = Substitute( + "Not all filters arrived (arrived: [$0], missing [$1]), waited for $2", + join(arrived_filter_ids, ", "), join(missing_filter_ids, ", "), wait_time); runtime_profile()->AddInfoString("Runtime filters", filter_str); VLOG_QUERY << filter_str; return false;
