IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout A previous commit attempted to fix IMPALA-4868 by waiting longer for a new file to become visible to the Impala code responsible for parsing the admission control config file. The timeout was observed in another gerrit-verify job, so we should increase this timeout further. I don't see any indication that there is anything else wrong with the test, or that any other kind of failure occurred.
This change gives the test up to 20 seconds for the new file to become visible and processed by the RequestPoolService. Change-Id: I0b98d69fc3aa61a317944950d14eb93e1737250c Reviewed-on: http://gerrit.cloudera.org:8080/7118 Reviewed-by: Matthew Jacobs <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/266cd53c Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/266cd53c Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/266cd53c Branch: refs/heads/master Commit: 266cd53c1ccd5a0dcfbcf2c26d98e5e561c2fae5 Parents: 605a271 Author: Matthew Jacobs <[email protected]> Authored: Thu Jun 8 13:08:39 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Wed Jun 21 20:23:20 2017 +0000 ---------------------------------------------------------------------- .../test/java/org/apache/impala/util/TestRequestPoolService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/266cd53c/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java ---------------------------------------------------------------------- diff --git a/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java b/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java index 4bb5d0c..7c7e9da 100644 --- a/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java +++ b/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java @@ -204,7 +204,7 @@ public class TestRequestPoolService { // the system is busy this may take even longer, so we need to try a few times. Thread.sleep(CHECK_INTERVAL_MS + AllocationFileLoaderService.ALLOC_RELOAD_WAIT_MS); - int numAttempts = 10; + int numAttempts = 20; while (true) { try { checkModifiedConfigResults();
