IMPALA-5507: Add clear description to help information of KEYVAL option Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of KEYVAL option. Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63 Reviewed-on: http://gerrit.cloudera.org:8080/7179 Reviewed-by: Jim Apple <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/36cca141 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/36cca141 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/36cca141 Branch: refs/heads/master Commit: 36cca141e0bff77b35e2890114dac41c3088e307 Parents: bd3b95e Author: davidxdh <[email protected]> Authored: Tue Jul 11 09:03:44 2017 +0800 Committer: Impala Public Jenkins <[email protected]> Committed: Tue Jul 11 11:05:14 2017 +0000 ---------------------------------------------------------------------- shell/option_parser.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/36cca141/shell/option_parser.py ---------------------------------------------------------------------- diff --git a/shell/option_parser.py b/shell/option_parser.py index 6092439..f0f3573 100755 --- a/shell/option_parser.py +++ b/shell/option_parser.py @@ -85,7 +85,8 @@ def get_option_parser(defaults): help="Execute a query without the shell") parser.add_option("-f", "--query_file", dest="query_file", help="Execute the queries in the query file, delimited by ;." - " Queries may be read from stdin if the argument to -f is -.") + " If the argument to -f is \"-\", then queries are read from" + " stdin and terminated with ctrl-d.") parser.add_option("-k", "--kerberos", dest="use_kerberos", action="store_true", help="Connect to a kerberized impalad") parser.add_option("-o", "--output_file", dest="output_file", @@ -157,7 +158,10 @@ def get_option_parser(defaults): parser.add_option("--ldap_password_cmd", help="Shell command to run to retrieve the LDAP password") parser.add_option("--var", dest="keyval", action="append", - help="Define variable(s) to be used within the Impala session.") + help="Define variable(s) to be used within the Impala session." + " It must follow the pattern \"KEY=VALUE\"," + " KEY starts with an alphabetic character and" + " contains alphanumeric characters or underscores.") # add default values to the help text for option in parser.option_list:
