Remove spurious forward declarations and includes in coordinator.cc/h While working on another patch, I noticed that a lot of includes and forward declarations were spurious and possibly the result of bit rot. This patch removes them and hopefully improves compile time a little.
Testing: Made sure that Impala and the BE tests compile successfully. Change-Id: Id0afed224fad6a00698701487b51506d414f83ac Reviewed-on: http://gerrit.cloudera.org:8080/7482 Reviewed-by: Sailesh Mukil <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/304edb28 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/304edb28 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/304edb28 Branch: refs/heads/master Commit: 304edb28c7acff4b188de651d21f122c0b26f465 Parents: 408b0aa Author: Sailesh Mukil <[email protected]> Authored: Fri Jul 21 15:31:27 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Sat Jul 22 08:10:27 2017 +0000 ---------------------------------------------------------------------- be/src/runtime/coordinator.cc | 13 ++----------- be/src/runtime/coordinator.h | 11 ----------- 2 files changed, 2 insertions(+), 22 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/304edb28/be/src/runtime/coordinator.cc ---------------------------------------------------------------------- diff --git a/be/src/runtime/coordinator.cc b/be/src/runtime/coordinator.cc index f904c48..e2d9c4a 100644 --- a/be/src/runtime/coordinator.cc +++ b/be/src/runtime/coordinator.cc @@ -40,42 +40,33 @@ #include "common/logging.h" #include "exec/data-sink.h" #include "exec/plan-root-sink.h" -#include "exec/scan-node.h" #include "gen-cpp/Frontend_types.h" #include "gen-cpp/ImpalaInternalService.h" #include "gen-cpp/ImpalaInternalService_constants.h" #include "gen-cpp/ImpalaInternalService_types.h" #include "gen-cpp/Partitions_types.h" #include "gen-cpp/PlanNodes_types.h" -#include "runtime/backend-client.h" -#include "runtime/client-cache.h" -#include "runtime/data-stream-mgr.h" -#include "runtime/data-stream-sender.h" #include "runtime/exec-env.h" #include "runtime/fragment-instance-state.h" #include "runtime/hdfs-fs-cache.h" #include "runtime/mem-tracker.h" -#include "runtime/parallel-executor.h" #include "runtime/query-exec-mgr.h" -#include "runtime/row-batch.h" -#include "runtime/tuple-row.h" #include "runtime/coordinator-filter-state.h" #include "runtime/coordinator-backend-state.h" #include "runtime/debug-options.h" #include "runtime/query-state.h" #include "scheduling/scheduler.h" #include "util/bloom-filter.h" -#include "util/container-util.h" #include "util/counting-barrier.h" #include "util/debug-util.h" #include "util/error-util.h" #include "util/hdfs-bulk-ops.h" #include "util/hdfs-util.h" +#include "util/histogram-metric.h" #include "util/network-util.h" #include "util/pretty-printer.h" -#include "util/summary-util.h" +#include "util/runtime-profile.h" #include "util/table-printer.h" -#include "util/uid-util.h" #include "common/names.h" http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/304edb28/be/src/runtime/coordinator.h ---------------------------------------------------------------------- diff --git a/be/src/runtime/coordinator.h b/be/src/runtime/coordinator.h index e3106b0..0401fa0 100644 --- a/be/src/runtime/coordinator.h +++ b/be/src/runtime/coordinator.h @@ -40,29 +40,18 @@ #include "gen-cpp/Types_types.h" #include "runtime/runtime-state.h" // for PartitionStatusMap; TODO: disentangle #include "scheduling/query-schedule.h" -#include "util/histogram-metric.h" #include "util/progress-updater.h" -#include "util/runtime-profile.h" namespace impala { class CountingBarrier; -class DataStreamMgr; -class DataSink; -class RowBatch; -class RowDescriptor; class ObjectPool; class RuntimeState; -class ExecEnv; class TUpdateCatalogRequest; -class TQueryExecRequest; class TReportExecStatusParams; -class TRowBatch; class TPlanExecRequest; class TRuntimeProfileTree; class RuntimeProfile; -class TablePrinter; -class TPlanFragment; class QueryResultSet; class MemTracker; class PlanRootSink;
