Repository: incubator-impala Updated Branches: refs/heads/master b70acf92b -> 6a606ed45
IMPALA-5109: Increase range of backend latency histogram Tiny change to increase range of backend start-up latency histogram to 30 minutes, with 4 s.f. of precision. This allows us to capture situations where some backend is very slow to start with more discrimination than the previous 20s upper bound. Change-Id: I7b6f39c0f769b5b590009d47f5b2e904f48fae8d Reviewed-on: http://gerrit.cloudera.org:8080/7676 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/6a606ed4 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/6a606ed4 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/6a606ed4 Branch: refs/heads/master Commit: 6a606ed459c173b50af7b1bd922970ac57fd17fc Parents: b70acf9 Author: Henry Robinson <[email protected]> Authored: Mon Aug 14 22:31:52 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Tue Aug 15 20:17:36 2017 +0000 ---------------------------------------------------------------------- be/src/runtime/coordinator.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/6a606ed4/be/src/runtime/coordinator.cc ---------------------------------------------------------------------- diff --git a/be/src/runtime/coordinator.cc b/be/src/runtime/coordinator.cc index 9687dcc..551e814 100644 --- a/be/src/runtime/coordinator.cc +++ b/be/src/runtime/coordinator.cc @@ -389,7 +389,8 @@ Status Coordinator::FinishBackendStartup() { Status status = Status::OK(); const TMetricDef& def = MakeTMetricDef("backend-startup-latencies", TMetricKind::HISTOGRAM, TUnit::TIME_MS); - HistogramMetric latencies(def, 20000, 3); + // Capture up to 30 minutes of start-up times, in ms, with 4 s.f. accuracy. + HistogramMetric latencies(def, 30 * 60 * 1000, 4); for (BackendState* backend_state: backend_states_) { // preserve the first non-OK, if there is one Status backend_status = backend_state->GetStatus();
