Hide some deprecated flags Hidden flags do not show up in /varz or --help.
Change-Id: I948b46cd6853f1d8ebaaadaba7b801dca886c7ad Reviewed-on: http://gerrit.cloudera.org:8080/7786 Reviewed-by: Lars Volker <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/74dad170 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/74dad170 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/74dad170 Branch: refs/heads/master Commit: 74dad1702aaa58f22ea98cbde25765190ff452a2 Parents: 91fc5b5 Author: Henry Robinson <[email protected]> Authored: Tue Aug 22 15:17:00 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Thu Aug 24 02:04:13 2017 +0000 ---------------------------------------------------------------------- be/src/exec/exec-node.cc | 4 ++-- be/src/exec/partitioned-hash-join-node.cc | 2 +- be/src/scheduling/query-schedule.cc | 6 +++--- be/src/service/impala-server.cc | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/74dad170/be/src/exec/exec-node.cc ---------------------------------------------------------------------- diff --git a/be/src/exec/exec-node.cc b/be/src/exec/exec-node.cc index b326d94..94e9ed1 100644 --- a/be/src/exec/exec-node.cc +++ b/be/src/exec/exec-node.cc @@ -71,8 +71,8 @@ using strings::Substitute; DECLARE_int32(be_port); DECLARE_string(hostname); -DEFINE_bool(enable_partitioned_hash_join, true, "Deprecated - has no effect"); -DEFINE_bool(enable_partitioned_aggregation, true, "Deprecated - has no effect"); +DEFINE_bool_hidden(enable_partitioned_hash_join, true, "Deprecated - has no effect"); +DEFINE_bool_hidden(enable_partitioned_aggregation, true, "Deprecated - has no effect"); namespace impala { http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/74dad170/be/src/exec/partitioned-hash-join-node.cc ---------------------------------------------------------------------- diff --git a/be/src/exec/partitioned-hash-join-node.cc b/be/src/exec/partitioned-hash-join-node.cc index 13d660f..2a1544c 100644 --- a/be/src/exec/partitioned-hash-join-node.cc +++ b/be/src/exec/partitioned-hash-join-node.cc @@ -38,7 +38,7 @@ #include "common/names.h" -DEFINE_bool(enable_phj_probe_side_filtering, true, "Deprecated."); +DEFINE_bool_hidden(enable_phj_probe_side_filtering, true, "Deprecated."); static const string PREPARE_FOR_READ_FAILED_ERROR_MSG = "Failed to acquire initial read buffer for stream in hash join node $0. Reducing " http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/74dad170/be/src/scheduling/query-schedule.cc ---------------------------------------------------------------------- diff --git a/be/src/scheduling/query-schedule.cc b/be/src/scheduling/query-schedule.cc index 244bef3..e14af78 100644 --- a/be/src/scheduling/query-schedule.cc +++ b/be/src/scheduling/query-schedule.cc @@ -36,9 +36,9 @@ using boost::uuids::uuid; using namespace impala; // TODO: Remove for Impala 3.0. -DEFINE_bool(rm_always_use_defaults, false, "Deprecated"); -DEFINE_string(rm_default_memory, "4G", "Deprecated"); -DEFINE_int32(rm_default_cpu_vcores, 2, "Deprecated"); +DEFINE_bool_hidden(rm_always_use_defaults, false, "Deprecated"); +DEFINE_string_hidden(rm_default_memory, "4G", "Deprecated"); +DEFINE_int32_hidden(rm_default_cpu_vcores, 2, "Deprecated"); namespace impala { http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/74dad170/be/src/service/impala-server.cc ---------------------------------------------------------------------- diff --git a/be/src/service/impala-server.cc b/be/src/service/impala-server.cc index b440845..41f84b1 100644 --- a/be/src/service/impala-server.cc +++ b/be/src/service/impala-server.cc @@ -210,7 +210,7 @@ DEFINE_bool(is_executor, true, "If true, this Impala daemon will execute query " #endif // TODO: Remove for Impala 3.0. -DEFINE_string(local_nodemanager_url, "", "Deprecated"); +DEFINE_string_hidden(local_nodemanager_url, "", "Deprecated"); DECLARE_bool(compact_catalog_topic);
