Repository: incubator-impala Updated Branches: refs/heads/master 03571788b -> 84233b297
IMPALA-4082: Remove todo item in getRegionsInRange HbaseTable.GetRegionsInRange is a function copied and modified from HTable in Hbase 0.95.1 or ealier. The HTable function uses cached region location and the modified version gets more up-to-date information. There is a todo item for the removal of this modified function if Hbase provides the same functionality itself. In Hbase 0.95.2, the HTable function is renamed to getKeysAndRegionsInRange and in Hbase 0.99 it became a private function. Thus this todo item is no longer needed and is removed by this patch. Change-Id: I35f0a3cd9363b55b3cde237beaf3037a7967582a Reviewed-on: http://gerrit.cloudera.org:8080/8018 Reviewed-by: Lars Volker <[email protected]> Reviewed-by: Alex Behm <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/84233b29 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/84233b29 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/84233b29 Branch: refs/heads/master Commit: 84233b297826524548be4476b8ee356f9d02f885 Parents: 0357178 Author: Tianyi Wang <[email protected]> Authored: Fri Sep 8 17:10:33 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Tue Sep 12 07:23:16 2017 +0000 ---------------------------------------------------------------------- .../java/org/apache/impala/catalog/HBaseTable.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/84233b29/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java ---------------------------------------------------------------------- diff --git a/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java b/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java index 43cf2b9..6df7c28 100644 --- a/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java +++ b/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java @@ -697,16 +697,16 @@ public class HBaseTable extends Table { } /** - * This is copied from org.apache.hadoop.hbase.client.HTable. The only difference is - * that it does not use cache when calling getRegionLocation. - * TODO: Remove this function and use HTable.getRegionsInRange (IMPALA-4082). * Get the corresponding regions for an arbitrary range of keys. - * <p> + * This is copied from org.apache.hadoop.hbase.client.HTable in HBase 0.95. The + * differences are: + * 1. It does not use cache when calling getRegionLocation. + * 2. It is synchronized on hbaseTbl. * - * @param startRow - * Starting row in range, inclusive - * @param endRow - * Ending row in range, exclusive + * @param startKey + * Starting key in range, inclusive + * @param endKey + * Ending key in range, exclusive * @return A list of HRegionLocations corresponding to the regions that * contain the specified range * @throws IOException
