IMPALA-5949: fix test_exchange_small_delay failure Avoid running the problematic query with short delays. This combination doesn't add coverage - the short delay was meant to test behaviour when multiple batches were sent, but there are deliberately no batches sent with this query.
Testing: Ran a build against Isilon, which succeeded. Ran the test in a loop locally overnight. Change-Id: Ia75c42be2de600344de7af5a917d7843880ea6de Reviewed-on: http://gerrit.cloudera.org:8080/8111 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/49532544 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/49532544 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/49532544 Branch: refs/heads/master Commit: 4953254409d5779b41b74c4b6b96c45cc49d6824 Parents: 98df907 Author: Tim Armstrong <[email protected]> Authored: Wed Sep 20 00:08:05 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Fri Sep 22 05:08:22 2017 +0000 ---------------------------------------------------------------------- .../queries/QueryTest/exchange-delays-zero-rows.test | 11 +++++++++++ .../queries/QueryTest/exchange-delays.test | 10 ---------- tests/custom_cluster/test_exchange_delays.py | 3 +++ 3 files changed, 14 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/49532544/testdata/workloads/functional-query/queries/QueryTest/exchange-delays-zero-rows.test ---------------------------------------------------------------------- diff --git a/testdata/workloads/functional-query/queries/QueryTest/exchange-delays-zero-rows.test b/testdata/workloads/functional-query/queries/QueryTest/exchange-delays-zero-rows.test new file mode 100644 index 0000000..79b7db4 --- /dev/null +++ b/testdata/workloads/functional-query/queries/QueryTest/exchange-delays-zero-rows.test @@ -0,0 +1,11 @@ +==== +---- QUERY +# IMPALA-5199: Query with zero rows sent over exchange. +select l_orderkey, count(*) +from tpch.lineitem +where l_linenumber = -1 +group by l_orderkey +---- RESULTS +---- CATCH +Sender timed out waiting for receiver fragment instance +==== http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/49532544/testdata/workloads/functional-query/queries/QueryTest/exchange-delays.test ---------------------------------------------------------------------- diff --git a/testdata/workloads/functional-query/queries/QueryTest/exchange-delays.test b/testdata/workloads/functional-query/queries/QueryTest/exchange-delays.test index b1f6f75..0dac1d9 100644 --- a/testdata/workloads/functional-query/queries/QueryTest/exchange-delays.test +++ b/testdata/workloads/functional-query/queries/QueryTest/exchange-delays.test @@ -8,13 +8,3 @@ from tpch.lineitem ---- CATCH Sender timed out waiting for receiver fragment instance ==== ----- QUERY -# IMPALA-5199: Query with zero rows sent over exchange. -select l_orderkey, count(*) -from tpch.lineitem -where l_linenumber = -1 -group by l_orderkey ----- RESULTS ----- CATCH -Sender timed out waiting for receiver fragment instance -==== http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/49532544/tests/custom_cluster/test_exchange_delays.py ---------------------------------------------------------------------- diff --git a/tests/custom_cluster/test_exchange_delays.py b/tests/custom_cluster/test_exchange_delays.py index a50ea13..eb82208 100644 --- a/tests/custom_cluster/test_exchange_delays.py +++ b/tests/custom_cluster/test_exchange_delays.py @@ -47,3 +47,6 @@ class TestExchangeDelays(CustomClusterTestSuite): resulted in the query hanging. """ self.run_test_case('QueryTest/exchange-delays', vector) + + # Test the special case when no batches are sent and the EOS message times out. + self.run_test_case('QueryTest/exchange-delays-zero-rows', vector)
