Repository: incubator-impala
Updated Branches:
refs/heads/master 2187d36b3 -> bf29ec53c
IMPALA-6049: breakpad tests: skip all tests with local filesystem
The breakpad tests were recently refactored to support inclusion of one
of them as a core test. In this refactor, we neglected to ensure
setup_class() called its parent. This means the skipping called in said
parent doesn't occur, and the test is executed in an unsupported
environment (local filesystem).
This patch fixes that by ensuring we call the parent setup_class() via
super().
Testing:
$ TARGET_FILESYSTEM="local" impala-py.test
tests/custom_cluster/test_breakpad.py \
-k test_abort_writes_minidump
tests/custom_cluster/test_breakpad.py::TestBreakpadCore::test_abort_writes_minidump
SKIPPED
Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Reviewed-on: http://gerrit.cloudera.org:8080/8272
Reviewed-by: Sailesh Mukil <[email protected]>
Reviewed-by: Lars Volker <[email protected]>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/bf29ec53
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/bf29ec53
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/bf29ec53
Branch: refs/heads/master
Commit: bf29ec53c3ee94db83e266cfcba0b95e7b82e3a9
Parents: 2187d36
Author: Michael Brown <[email protected]>
Authored: Fri Oct 13 09:19:09 2017 -0700
Committer: Impala Public Jenkins <[email protected]>
Committed: Sat Oct 14 01:02:08 2017 +0000
----------------------------------------------------------------------
tests/custom_cluster/test_breakpad.py | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/bf29ec53/tests/custom_cluster/test_breakpad.py
----------------------------------------------------------------------
diff --git a/tests/custom_cluster/test_breakpad.py
b/tests/custom_cluster/test_breakpad.py
index b77fb59..c9fa79c 100644
--- a/tests/custom_cluster/test_breakpad.py
+++ b/tests/custom_cluster/test_breakpad.py
@@ -52,6 +52,7 @@ class TestBreakpadBase(CustomClusterTestSuite):
@classmethod
def setup_class(cls):
+ super(TestBreakpadBase, cls).setup_class()
# Disable core dumps for this test
setrlimit(RLIMIT_CORE, (0, RLIM_INFINITY))
