IMPALA-6100: increase test_exchange_delays timeout on slow builds The timeout is doubled on build types known to be slow to reduce the odds of hitting the flakiness.
Testing: I wasn't able to reproduce the original problem locally. However I was able to reproduce a similar problem by decreasing the timeout to 2000ms, which suggests that > 1s hiccups are possible with an ASAN build, so increasing the timeout could help. Change-Id: Ib00cb3c63c123b7ff263e21c7ee41fa6af12606f Reviewed-on: http://gerrit.cloudera.org:8080/8357 Reviewed-by: Michael Brown <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/6ae08ef9 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/6ae08ef9 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/6ae08ef9 Branch: refs/heads/master Commit: 6ae08ef98b3de3261940c737fda816cae100117a Parents: f05bd24 Author: Tim Armstrong <[email protected]> Authored: Mon Oct 23 11:32:18 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Mon Oct 23 23:22:16 2017 +0000 ---------------------------------------------------------------------- tests/custom_cluster/test_exchange_delays.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/6ae08ef9/tests/custom_cluster/test_exchange_delays.py ---------------------------------------------------------------------- diff --git a/tests/custom_cluster/test_exchange_delays.py b/tests/custom_cluster/test_exchange_delays.py index eb82208..01acaef 100644 --- a/tests/custom_cluster/test_exchange_delays.py +++ b/tests/custom_cluster/test_exchange_delays.py @@ -17,8 +17,12 @@ import pytest from tests.common.custom_cluster_test_suite import CustomClusterTestSuite +from tests.common.environ import specific_build_type_timeout from tests.common.skip import SkipIfBuildType +# IMPALA-6100: add additional margin for error for slow build types. +DELAY_MS = specific_build_type_timeout(10000, slow_build_timeout=20000) + @SkipIfBuildType.not_dev_build class TestExchangeDelays(CustomClusterTestSuite): """Tests for handling delays in finding data stream receivers""" @@ -28,8 +32,9 @@ class TestExchangeDelays(CustomClusterTestSuite): return 'functional-query' @pytest.mark.execute_serially - @CustomClusterTestSuite.with_args("--stress_datastream_recvr_delay_ms=10000" - " --datastream_sender_timeout_ms=5000") + @CustomClusterTestSuite.with_args( + "--stress_datastream_recvr_delay_ms={0}".format(DELAY_MS) + + " --datastream_sender_timeout_ms=5000") def test_exchange_small_delay(self, vector): """Test delays in registering data stream receivers where the first one or two batches will time out before the receiver registers, but subsequent batches will @@ -39,8 +44,9 @@ class TestExchangeDelays(CustomClusterTestSuite): self.run_test_case('QueryTest/exchange-delays', vector) @pytest.mark.execute_serially - @CustomClusterTestSuite.with_args("--stress_datastream_recvr_delay_ms=10000" - " --datastream_sender_timeout_ms=1") + @CustomClusterTestSuite.with_args( + "--stress_datastream_recvr_delay_ms={0}".format(DELAY_MS) + + " --datastream_sender_timeout_ms=1") def test_exchange_large_delay(self, vector): """Test delays in registering data stream receivers where all of the batches sent will time out before the receiver registers. Before IMPALA-2987, this scenario
