Repository: incubator-impala
Updated Branches:
refs/heads/master 6b37a793a -> e6c3a01b9
Fix errant, newline-including log directory.
We've seen cases where a directory named "cluster\n " sneaks
into the logs directory. The intention is that $IMPALA_ALL_LOGS_DIRS
is a space-separated list, but clean.sh (as opposed to buildall.sh)
treats it as a single argument.
I tested this manually:
Before:
$ls logs/
be_tests/ custom_cluster_tests/ data_loading/ ee_tests/ fe_tests/
Bad command:
$mkdir -p "${IMPALA_ALL_LOGS_DIRS}"
After:
$ls logs/
be_tests/ cluster? / custom_cluster_tests/ data_loading/ ee_tests/
fe_tests/
Change-Id: Id18404c3f3fc0008f67b01afbac9d908532fc317
Reviewed-on: http://gerrit.cloudera.org:8080/8459
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/ca680b61
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/ca680b61
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/ca680b61
Branch: refs/heads/master
Commit: ca680b61e1e8bbb36e6a1dfa9617d796c7e9702d
Parents: 6b37a79
Author: Philip Zeyliger <[email protected]>
Authored: Fri Nov 3 11:09:19 2017 -0700
Committer: Impala Public Jenkins <[email protected]>
Committed: Sat Nov 4 01:42:27 2017 +0000
----------------------------------------------------------------------
bin/clean.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/ca680b61/bin/clean.sh
----------------------------------------------------------------------
diff --git a/bin/clean.sh b/bin/clean.sh
index a8a42c1..89a991c 100755
--- a/bin/clean.sh
+++ b/bin/clean.sh
@@ -42,7 +42,7 @@ rm -rf target
rm -f src/test/resources/{core,hbase,hive}-site.xml
rm -rf generated-sources/*
[ -z "${IMPALA_LOGS_DIR}" ] || rm -rf "${IMPALA_LOGS_DIR}"/*
-mkdir -p "${IMPALA_ALL_LOGS_DIRS}"
+mkdir -p ${IMPALA_ALL_LOGS_DIRS}
popd
# clean be
