gosonzhang commented on a change in pull request #476:
URL: https://github.com/apache/incubator-inlong/pull/476#discussion_r644640026
##########
File path:
tubemq-core/src/main/java/org/apache/tubemq/corebase/config/constants/BrokerCfgConst.java
##########
@@ -1,3 +1,20 @@
+/**
Review comment:
The constant definitions and token definitions of the server module
should be summarized in the server module and do not need to be known by the
client
##########
File path: pom.xml
##########
@@ -115,8 +115,8 @@
// Therefore, the project uses jdk1.7 uniformly,
// but the server module is specified separately for
version 1.8
-->
- <source>1.7</source>
- <target>1.7</target>
+ <source>1.8</source>
Review comment:
Ignored the precautions requirements, which will force the client
environment to be a 1.8 JDK
##########
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/common/fileconfig/AbstractFileConfig.java
##########
@@ -22,7 +22,8 @@
import java.util.Set;
Review comment:
Supplementary unit test: There are many modifications, and it is the
module that is not easy to consider when a problem occurs. It is necessary to
supplement unit test cases to cover the scope of modification to ensure that
the results of configuration settings and non-settings are consistent with
those before the modification
##########
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/broker/BrokerConfig.java
##########
@@ -42,64 +43,64 @@
static final long serialVersionUID = -1L;
private static final Logger logger =
LoggerFactory.getLogger(BrokerConfig.class);
// broker id
- private int brokerId = ConfigConstants.DEFAULT_BROKER_ID;
+ private int brokerId = BrokerCfgConst.DEFAULT_BROKER_ID;
// default NetworkInterface
- private String defEthName = ConfigConstants.DEFAULT_DEF_ETH_NAME;
+ private String defEthName = BrokerCfgConst.DEFAULT_DEF_ETH_NAME;
// broker hostname
private String hostName;
// broker port
private int port = TBaseConstants.META_DEFAULT_BROKER_PORT;
// broker web service port
- private int webPort = ConfigConstants.DEFAULT_BROKER_WEB_PORT;
+ private int webPort = BrokerCfgConst.DEFAULT_BROKER_WEB_PORT;
// master service address
private String masterAddressList;
private String primaryPath;
// tcp write service thread count
- private int tcpWriteServiceThread =
ConfigConstants.DEFAULT_TCP_WRITE_SERVICE_THREAD;
+ private int tcpWriteServiceThread =
BrokerCfgConst.DEFAULT_TCP_WRITE_SERVICE_THREAD;
// tcp read service thread count
- private int tcpReadServiceThread =
ConfigConstants.DEFAULT_TCP_READ_SERVICE_THREAD;
+ private int tcpReadServiceThread =
BrokerCfgConst.DEFAULT_TCP_READ_SERVICE_THREAD;
// tls write service thread count
- private int tlsWriteServiceThread =
ConfigConstants.DEFAULT_TLS_WRITE_SERVICE_THREAD;
+ private int tlsWriteServiceThread =
BrokerCfgConst.DEFAULT_TLS_WRITE_SERVICE_THREAD;
// tls read service thread count
- private int tlsReadServiceThread =
ConfigConstants.DEFAULT_TLS_READ_SERVICE_THREAD;
- private long defaultDeduceReadSize =
ConfigConstants.DEFAULT_DEFAULT_DEDUCE_READ_SIZE;
+ private int tlsReadServiceThread =
BrokerCfgConst.DEFAULT_TLS_READ_SERVICE_THREAD;
+ private long defaultDeduceReadSize =
BrokerCfgConst.DEFAULT_DEFAULT_DEDUCE_READ_SIZE;
private long defaultDoubleDeduceReadSize = this.defaultDeduceReadSize * 2;
// max data segment size
- private int maxSegmentSize = ConfigConstants.DEFAULT_MAX_SEGMENT_SIZE;
+ private int maxSegmentSize = BrokerCfgConst.DEFAULT_MAX_SEGMENT_SIZE;
// max index segment size
- private int maxIndexSegmentSize =
ConfigConstants.DEFAULT_MAX_INDEX_SEGMENT_SIZE;
+ private int maxIndexSegmentSize = 700000 *
DataStoreUtils.STORE_INDEX_HEAD_LEN;
Review comment:
Need to maintain consistent macro definitions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
