gosonzhang opened a new issue #1911:
URL: https://github.com/apache/incubator-inlong/issues/1911


   ### What happened
   
   I analyzed the metric implementation in the common module[1], and there are 
a few issues that need to be corrected, or they can’t be connected with the 
external standard JMX call.
   a. To be implemented based on MXBean instead of MBean;
       MBean can only provide the call of the basic class, and the composite 
class needs MXBean to define
   b. The name format of the constructed Beanobject should be unified:
       To be constructed based on ObjectName("XXXX:type=YYYYY") format, where 
XXXX and YYYYYare arbitrary, but ":type=" is a fixed format
   c. Cannot only have get-and-reset() API:
       If we only have the get-and-reset() API, when we look at Counter type 
indicators, we still need the caller to keep the previous data and accumulate 
it by itself, which is unreasonable.
   
   1. 
https://github.com/apache/incubator-inlong/tree/master/inlong-common/src/main/java/org/apache/inlong/commons/config/metrics
   
   ### What you expected to happen
   
   Use standard JMX tools, for example, jconsole, for interface access
   
   ### How to reproduce
   
   Use standard JMX tools, for example, jconsole, for interface access
   
   ### Environment
   
   _No response_
   
   ### InLong version
   
   master
   
   ### InLong Component
   
   Other for not specified component
   
   ### Are you willing to submit PR?
   
   - [ ] Yes, I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to