chantccc commented on a change in pull request #2022:
URL: https://github.com/apache/incubator-inlong/pull/2022#discussion_r775383191
##########
File path:
inlong-sort/sort-core/src/main/java/org/apache/inlong/sort/meta/ZookeeperWatcher.java
##########
@@ -38,10 +39,16 @@
import org.apache.curator.framework.recipes.cache.PathChildrenCacheListener;
import org.apache.curator.framework.state.ConnectionState;
import org.apache.curator.framework.state.ConnectionStateListener;
+import org.apache.inlong.sort.configuration.Configuration;
+import org.apache.inlong.sort.configuration.Constants;
+import org.apache.inlong.sort.meta.MetaManager.DataFlowInfoListener;
+import org.apache.inlong.sort.util.ZooKeeperUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class ZookeeperWatcher implements AutoCloseable, UnhandledErrorListener
{
+import com.google.common.base.Preconditions;
+
+public class ZookeeperWatcher implements AutoCloseable,
UnhandledErrorListener, MetaWatcher {
Review comment:
ZookeeperWatcher is a basic util class wrapping zk related operations.
It should not implement MetaWatcher.
Use another class ZookeeperMetaWatcher which implements MetaWatcher instead.
##########
File path:
inlong-sort/sort-core/src/main/java/org/apache/inlong/sort/meta/ZookeeperWatcher.java
##########
@@ -50,26 +57,52 @@
/**
* Connection to the used ZooKeeper quorum.
*/
- private final CuratorFramework client;
+ private CuratorFramework client;
/**
* Curator recipe to watch changes of a specific ZooKeeper node.
*/
@GuardedBy("lock")
- private final Map<String, NodeCache> caches;
+ private Map<String, NodeCache> caches;
@GuardedBy("lock")
- private final Map<String, PathChildrenCache> pathChildrenCaches;
+ private Map<String, PathChildrenCache> pathChildrenCaches;
- private final ConnectionStateListener connectionStateListener =
- (client, newState) -> handleStateChange(newState);
+ private ConnectionStateListener connectionStateListener = (client,
newState) -> handleStateChange(newState);
- public ZookeeperWatcher(CuratorFramework client) {
- this.client = checkNotNull(client, "CuratorFramework client");
+ /**
Review comment:
descriptions of param are empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
