gosonzhang commented on a change in pull request #2067:
URL: https://github.com/apache/incubator-inlong/pull/2067#discussion_r775756249
##########
File path:
inlong-tubemq/tubemq-client-twins/tubemq-client-go/client/consumer_impl.go
##########
@@ -280,7 +280,8 @@ func (c *consumer) Confirm(confirmContext string, consumed
bool) (*ConsumerResul
return nil, errs.New(errs.RetErrConfirmTimeout, "Not found the
partition by confirm_context!")
}
- rsp, err := c.sendConfirmReq2Broker(partition)
+ defer c.rmtDataCache.ReleasePartition(true,
c.subInfo.IsFiltered(topic), confirmContext, consumed)
Review comment:
Sending a confirm request after release is prone to misconfirmation
problems:
The partition is released, the second getMessage starts, the first confirm
arrives, and the second getMessage is confirmed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
