luchunliang commented on a change in pull request #2022:
URL: https://github.com/apache/incubator-inlong/pull/2022#discussion_r775779767



##########
File path: 
inlong-sort/sort-core/src/main/java/org/apache/inlong/sort/meta/zookeeper/ZookeeperWatcherUtils.java
##########
@@ -337,4 +377,95 @@ public void childEvent(
             }
         }
     }
+
+    private static class DataFlowsChildrenWatcherListener implements 
ChildrenWatcherListener {

Review comment:
       ZookeeperMetaWatcher implements MetaWatcher.
   ZookeeperWatcherUtils is a basic util class.
   
   chantccc yesterday
   ZookeeperWatcher is a basic util class wrapping zk related operations. It 
should not implement MetaWatcher.
   Use another class ZookeeperMetaWatcher which implements MetaWatcher instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to