wardlican commented on a change in pull request #2186:
URL: https://github.com/apache/incubator-inlong/pull/2186#discussion_r788338640
##########
File path:
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/impl/InLongTopicManagerImpl.java
##########
@@ -152,13 +176,15 @@ public boolean clean() {
}
closeFetcher();
- result = true;
- logger.info("close finished {} {}", sortTaskId, result);
+ closePulsarClient();
+ closeTubeSessionFactory();
Review comment:
The closing logic here belongs to the manager, and the specific closing
implementation is in the fetcher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
