aloyszhang commented on a change in pull request #2415:
URL: https://github.com/apache/incubator-inlong/pull/2415#discussion_r802271854
##########
File path:
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/plugin/PluginService.java
##########
@@ -50,7 +50,7 @@
private List<PluginBinder> pluginBinders;
@Getter
- private List<Plugin> plugins = new ArrayList<>();
+ private final List<Plugin> plugins = new ArrayList<>();
Review comment:
for uniqueness, maybe using a Set<Plugin> here is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
