imvan commented on a change in pull request #2439:
URL: https://github.com/apache/incubator-inlong/pull/2439#discussion_r804474496
##########
File path:
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/SortServiceImpl.java
##########
@@ -80,12 +83,14 @@ public SortClusterConfigResponse getClusterConfig(String
clusterName, String md5
private SortTaskConfig getTaskConfig(SortClusterConfigEntity
clusterConfig) {
List<Map<String, String>> idParams =
sortTaskIdParamService.selectByTaskName(clusterConfig.getTaskName());
- // TODO add method that get sink params
+ Map<String, String> sinkParams =
+ sortTaskSinkParamService
+ .selectByTaskNameAndType(clusterConfig.getTaskName(),
clusterConfig.getSinkType());
return SortTaskConfig.builder()
.taskName(clusterConfig.getTaskName())
.sinkType(SinkType.valueOf(clusterConfig.getSinkType().toUpperCase()))
Review comment:
fixed， the illegalArgument exception will be catched in upper method,
and the response to user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
