healchow commented on a change in pull request #2493:
URL: https://github.com/apache/incubator-inlong/pull/2493#discussion_r808666115
##########
File path:
inlong-manager/manager-dao/src/main/resources/mappers/DataProxyPulsarMapper.xml
##########
@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
Is this file still needed?
##########
File path:
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/ClusterInfoMapper.java
##########
@@ -42,4 +43,6 @@
List<ClusterInfoEntity> selectByCondition(ClusterRequest request);
+ List<ClusterInfoEntity> selectByMqSetName(String mqSetName);
Review comment:
Its suggested to add `mqSetName` into `ClusterRequest`.
##########
File path:
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/DataProxyClusterEntityMapper.java
##########
@@ -43,4 +42,6 @@
int updateByPrimaryKey(DataProxyClusterEntity record);
+ DataProxyClusterEntity selectByName(String proxyClusterName);
Review comment:
Its suggested to add `proxyClusterName` into
`DataProxyClusterPageRequest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
