aloyszhang commented on a change in pull request #2551:
URL: https://github.com/apache/incubator-inlong/pull/2551#discussion_r808741326
##########
File path:
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/send/SenderManager.java
##########
@@ -164,7 +164,7 @@ private void sendData(byte[] data) {
* Clean up the backlog of unsent message packets
*/
public void clearBuffer() {
- logger.info("failed cache size:" + this.dataMap.size());
+ logger.info("audit failed cache size:" + this.dataMap.size());
Review comment:
For consistency, it's better to use a placeholder rather than `+` in
log.
```java
logger.info("audit failed cache size : {}", this.dataMap.size());
```
##########
File path:
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/send/SenderManager.java
##########
@@ -283,6 +283,7 @@ public void onMessageReceived(ChannelHandlerContext ctx,
MessageEvent e) {
logger.error("can not find the requestid onMessageReceived:" +
requestId);
return;
}
+ logger.info("audit-proxy response code:" +
baseCommand.getAuditReply().getRspCode().toString());
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
