imvan commented on a change in pull request #2713:
URL: https://github.com/apache/incubator-inlong/pull/2713#discussion_r814767350
##########
File path:
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/impl/tube/InLongTubeFetcherImpl.java
##########
@@ -174,6 +174,15 @@ public long getAckedOffset() {
return 0L;
}
+ /**
+ * isValidState
+ */
+ public void isValidState() {
Review comment:
why not return false, but throw exception in the method called isxxx
when the state is invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
