[GitHub] [incubator-inlong] Greedyu opened a new pull request #2762: [INLONG-2759][INLONG-2760][Manager] Fix InlongGroup object deletion and modification exception

[GitBox]

Greedyu opened a new pull request #2762:
URL: https://github.com/apache/incubator-inlong/pull/2762


   ### Title Name: [INLONG-2759][INLONG-2760][Manager] Fix InlongGroup object 
deletion and modification exception
   
   Fixes #2759  Manager module
   First of all, the reason is that the GroupState.forCode() function has 
passed a null value. The reason is that the request object InlongGroupRequest 
does not add the annotation @ApiModelProperty() to the status field, which has 
been fixed here.
   
   But there is still a problem with retesting with annotations, because the 
front-end page does not pass in the status parameter.
   <img width="1656" alt="image" 
src="https://user-images.githubusercontent.com/20356765/155844608-8e618d60-a54d-4fa0-ac35-4c5db55a0377.png";>
   
   Then continue to use the postman tool to form the status parameter for 
testing. A new problem has arisen: Current state=wait_submit is not allowed to 
transfer to state=wait_submit
   <img width="1033" alt="image" 
src="https://user-images.githubusercontent.com/20356765/155844678-7ed40980-d3f3-4495-aff1-80b36a2c8b92.png";>
   
   This is because there is no conversion from GROUP_WAIT_SUBMIT to 
GROUP_WAIT_SUBMIT in the status transition. The above scenario should be missed 
here, so I fixed it and tested it again through the post. Finally verified 
successfully
   
   <img width="1067" alt="image" 
src="https://user-images.githubusercontent.com/20356765/155844789-ecd97e6e-a30f-4fed-81c1-da9bf90ac545.png";>
   
   Finally, the front-end Dashborad module needs to be repaired and the status 
parameter added.
   
   Fixes #2760 
   Because the deletion actually calls the 
groupProcessOperation.deleteProcess() function, the InlongGroupRequest queried 
according to the id does not change the state. In the inner layer, the 
groupService.update(groupInfo, username) method is actually executed first. 
equivalent to the original state of transformation
   <img width="1180" alt="image" 
src="https://user-images.githubusercontent.com/20356765/155845850-0a074567-998f-468f-bcaf-e866c1f8346c.png";>
   
   After repairing and testing again, the interface can return successfully
   <img width="681" alt="image" 
src="https://user-images.githubusercontent.com/20356765/155845859-1ced09ad-19a6-444b-b6ea-5fb8e10d665c.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org