kipshi commented on a change in pull request #3118:
URL: https://github.com/apache/incubator-inlong/pull/3118#discussion_r825638276



##########
File path: 
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/SinkField.java
##########
@@ -33,10 +33,14 @@
     @ApiModelProperty("Source field type")
     private String sourceFieldType;
 
+    @ApiModelProperty("Is source builtin, 0: no, 1: yes")
+    private Integer isSourceBuiltin = 0;
+
     public SinkField(int index, FieldType fieldType, String fieldName, String 
fieldComment,
-            String fieldValue, String sourceFieldName, String sourceFieldType) 
{
+            String fieldValue, String sourceFieldName, String sourceFieldType, 
Integer isSourceBuiltin) {

Review comment:
       'isSourceBuiltin' is difficult to understand ,  use metaField instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to