baomingyu commented on a change in pull request #3162:
URL: https://github.com/apache/incubator-inlong/pull/3162#discussion_r827619889
##########
File path:
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source/ServerMessageHandler.java
##########
@@ -442,6 +442,10 @@ private void formatMessagesAndSend(ChannelHandlerContext
ctx, Map<String, String
headers.put(AttributeConstants.DATA_TIME,
String.valueOf(System.currentTimeMillis()));
}
+ if
("false".equals(commonAttrMap.get(AttributeConstants.MESSAGE_IS_ACK))) {
+ headers.put(AttributeConstants.MESSAGE_IS_ACK, "false");
+ }
Review comment:
just false need to be handle.
##########
File path:
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source/ServerMessageHandler.java
##########
@@ -525,7 +529,8 @@ private void responsePackage(ChannelHandlerContext ctx,
Map<String, String> comm
Channel remoteChannel,
SocketAddress remoteSocketAddress,
MsgType msgType) throws Exception {
- if (!commonAttrMap.containsKey("isAck") ||
"true".equals(commonAttrMap.get("isAck"))) {
+ if (!commonAttrMap.containsKey(AttributeConstants.MESSAGE_IS_ACK)
+ ||
"true".equals(commonAttrMap.get(AttributeConstants.MESSAGE_IS_ACK))) {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
