EMsnap commented on code in PR #3522:
URL: https://github.com/apache/incubator-inlong/pull/3522#discussion_r843434113
##########
inlong-tubemq/tubemq-manager/src/main/java/org/apache/inlong/tubemq/manager/controller/cluster/ClusterController.java:
##########
@@ -156,9 +166,9 @@ private TubeMQResult queryAllClusterVo() {
List<ClusterEntry> allClusters = clusterService.getAllClusters();
List<ClusterVo> clusterVos = Lists.newArrayList();
for (ClusterEntry cluster : allClusters) {
- MasterEntry masterNode =
masterService.getMasterNode(cluster.getClusterId());
+ List<MasterEntry> masterNodes =
masterService.getMasterNodes(cluster.getClusterId());
ClusterVo allCount = getAllCount(Integer.valueOf((int)
cluster.getClusterId()));
Review Comment:
getAllCount -> getCountInCluster
##########
inlong-tubemq/tubemq-manager/src/main/java/org/apache/inlong/tubemq/manager/service/interfaces/MasterService.java:
##########
@@ -75,6 +75,13 @@
*/
List<MasterEntry> getMasterNodes(Long clusterId);
+ /**
+ * get master in master ip
Review Comment:
get master by master ip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
