gong commented on code in PR #3554:
URL: https://github.com/apache/incubator-inlong/pull/3554#discussion_r844621578


##########
inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/util/FlinkUtils.java:
##########
@@ -106,6 +105,16 @@ public static String findFiles(String baseDirName,String 
pattern) {
         return null;
     }
 
+    /**
+     * get value
+     * @param key
+     * @param defaultValue
+     * @return
+     */
+    public static String getValue(String key, String defaultValue) {

Review Comment:
   set default `""` is redundancy. Because `FlinkService` will use value of 
config file to fill value by judging `endpoint` is empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to