healchow commented on code in PR #3689:
URL: https://github.com/apache/incubator-inlong/pull/3689#discussion_r850062054
##########
inlong-agent/agent-plugins/src/test/java/org/apache/inlong/agent/plugin/sources/TestBinlogOffsetManager.java:
##########
@@ -28,16 +27,22 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
public class TestBinlogOffsetManager {
private static final Logger LOGGER =
LoggerFactory.getLogger(TestBinlogOffsetManager.class);
Review Comment:
Remove this unused line.
##########
inlong-agent/agent-plugins/src/test/java/org/apache/inlong/agent/plugin/sources/TestBinlogOffsetManager.java:
##########
@@ -28,16 +27,22 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
public class TestBinlogOffsetManager {
private static final Logger LOGGER =
LoggerFactory.getLogger(TestBinlogOffsetManager.class);
private static Path testDir;
private static AgentBaseTestsHelper helper;
+ private static String fileName = "test.txt";
Review Comment:
Add `final`.
##########
inlong-agent/agent-plugins/src/test/java/org/apache/inlong/agent/plugin/sources/TestBinlogOffsetManager.java:
##########
@@ -28,16 +27,22 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
public class TestBinlogOffsetManager {
private static final Logger LOGGER =
LoggerFactory.getLogger(TestBinlogOffsetManager.class);
private static Path testDir;
Review Comment:
Convert to local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
