vernedeng commented on code in PR #3733:
URL: https://github.com/apache/incubator-inlong/pull/3733#discussion_r851175183
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/thirdparty/sort/util/SinkInfoUtils.java:
##########
@@ -56,12 +59,20 @@ public class SinkInfoUtils {
private static final String DATA_FORMAT = "yyyyMMddHH";
private static final String TIME_FORMAT = "HHmmss";
private static final String DATA_TIME_FORMAT = "yyyyMMddHHmmss";
+ private static final String KEY_TYPE_CUSTOM_SINK_INFO_GENERATOR =
"CustomSinkInfoGenerator.type";
/**
* Create sink info for DataFlowInfo.
*/
public static SinkInfo createSinkInfo(SourceResponse sourceResponse,
SinkResponse sinkResponse,
- List<FieldInfo> sinkFields) {
+ List<FieldInfo> sinkFields, Map<String, Object> properties) {
+
+ String loadType =
String.valueOf(properties.get(KEY_TYPE_CUSTOM_SINK_INFO_GENERATOR));
+ if (!("null".equalsIgnoreCase(loadType))) {
Review Comment:
thx, it will reduce one _String_ initialization in the case that there is no
custom plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
