healchow commented on code in PR #3784:
URL: https://github.com/apache/incubator-inlong/pull/3784#discussion_r852564063
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/FieldInfo.java:
##########
@@ -35,34 +41,47 @@
@JsonSubTypes.Type(value = FieldInfo.class, name = "base"),
@JsonSubTypes.Type(value = BuiltInFieldInfo.class, name = "builtin")
})
-public class FieldInfo implements Serializable {
+@Data
+public class FieldInfo implements FunctionParam, Serializable {
private static final long serialVersionUID = 5871970550803344673L;
-
@JsonProperty("name")
private final String name;
-
+ @JsonInclude(Include.NON_NULL)
+ @JsonProperty("nodeId")
+ private String nodeId;
+ @JsonIgnore
+ private String tableNameAlias;
@JsonProperty("format_info")
private FormatInfo formatInfo;
- @JsonCreator
public FieldInfo(
@JsonProperty("name") String name,
@JsonProperty("format_info") FormatInfo formatInfo) {
this.name = Preconditions.checkNotNull(name);
this.formatInfo = Preconditions.checkNotNull(formatInfo);
}
- public String getName() {
- return name;
- }
-
- public FormatInfo getFormatInfo() {
- return formatInfo;
+ @JsonCreator
+ public FieldInfo(
+ @JsonProperty("name") String name,
+ @JsonProperty("nodeId") String nodeId,
+ @JsonProperty("format_info") FormatInfo formatInfo) {
+ this.name = Preconditions.checkNotNull(name);
+ this.nodeId = nodeId;
+ this.formatInfo = Preconditions.checkNotNull(formatInfo);
}
- public void setFormatInfo(FormatInfo formatInfo) {
- this.formatInfo = formatInfo;
+ @Override
+ public String format() {
+ String formatName = name.trim();
+ if (!formatName.startsWith("`")) {
+ formatName = String.format("`%s`", formatName);
Review Comment:
Maybe the format name will end with "`", suggest adding a check.
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/FieldInfo.java:
##########
@@ -35,34 +41,47 @@
@JsonSubTypes.Type(value = FieldInfo.class, name = "base"),
@JsonSubTypes.Type(value = BuiltInFieldInfo.class, name = "builtin")
})
-public class FieldInfo implements Serializable {
+@Data
+public class FieldInfo implements FunctionParam, Serializable {
private static final long serialVersionUID = 5871970550803344673L;
-
@JsonProperty("name")
private final String name;
-
+ @JsonInclude(Include.NON_NULL)
+ @JsonProperty("nodeId")
+ private String nodeId;
+ @JsonIgnore
+ private String tableNameAlias;
@JsonProperty("format_info")
private FormatInfo formatInfo;
- @JsonCreator
public FieldInfo(
@JsonProperty("name") String name,
@JsonProperty("format_info") FormatInfo formatInfo) {
this.name = Preconditions.checkNotNull(name);
this.formatInfo = Preconditions.checkNotNull(formatInfo);
}
- public String getName() {
- return name;
- }
-
- public FormatInfo getFormatInfo() {
- return formatInfo;
+ @JsonCreator
+ public FieldInfo(
+ @JsonProperty("name") String name,
+ @JsonProperty("nodeId") String nodeId,
+ @JsonProperty("format_info") FormatInfo formatInfo) {
Review Comment:
Would it be better to name those variables with the Camel Case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
