woofyzhao commented on code in PR #4041:
URL: https://github.com/apache/incubator-inlong/pull/4041#discussion_r862641758


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/SinkInfoUtils.java:
##########
@@ -182,13 +183,15 @@ private static HiveSinkInfo 
createHiveSinkInfo(HiveSinkResponse hiveInfo, List<F
             }).collect(Collectors.toList());
         }
 
-        // dataPath = dataPath + / + tableName
-        StringBuilder dataPathBuilder = new StringBuilder();
+        // dataPath = dataPath + / + dbName + / + tableName

Review Comment:
   Added compatibility for the default db case.
   
   No matter where  you create hive table the table name must be part of the 
path and must also be specified here to let sort write to the correct file. The 
default hive approach is fine. All that's left is to take the default database 
case into account. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to