gosonzhang commented on code in PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062#discussion_r865724027
##########
inlong-tubemq/tubemq-core/src/main/java/org/apache/inlong/tubemq/corerpc/netty/NettyClientFactory.java:
##########
@@ -235,15 +238,13 @@ private Client createClient(final NodeAddrInfo
addressInfo,
conf.getInt(RpcConstants.NETTY_WRITE_HIGH_MARK, -1);
int nettyWriteLowMark =
conf.getInt(RpcConstants.NETTY_WRITE_LOW_MARK, -1);
- if (nettyWriteHighMark > 0) {
- clientBootstrap.option(ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK,
nettyWriteHighMark);
- }
- if (nettyWriteLowMark > 0) {
- clientBootstrap.option(ChannelOption.WRITE_BUFFER_LOW_WATER_MARK,
nettyWriteLowMark);
+ if (nettyWriteHighMark > 0 && nettyWriteLowMark > 0) {
Review Comment:
What if the user only needs to modify nettyWriteHighMark or
nettyWriteLowMark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
