shink commented on code in PR #4121:
URL: https://github.com/apache/incubator-inlong/pull/4121#discussion_r867426661
##########
docker/kubernetes/templates/tubemq-broker-ini-configmap.yaml:
##########
@@ -26,7 +26,7 @@ data:
broker.ini.raw: |
[broker]
brokerId=REPLACE_BY_POD_ID
- hostName=REPLACE_BY_POD_HOSTNAME
+ hostName=REPLACE_BY_POD_IP
port=8123
webPort=8081
Review Comment:
@dockerzhang These ports are configurable. It should not be hard-coded.
```suggestion
port={{ .Values.tubemqBroker.ports.rpcPort }}
webPort={{ .Values.tubemqBroker.ports.webPort }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
