thexiay commented on code in PR #4159:
URL: https://github.com/apache/incubator-inlong/pull/4159#discussion_r869975267
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/HiveLoadNode.java:
##########
@@ -88,7 +90,7 @@ public HiveLoadNode(@JsonProperty("id") String id,
@JsonProperty("hiveVersion") String hiveVersion,
@JsonProperty("hadoopConfDir") String hadoopConfDir,
@JsonProperty("parFields") List<FieldInfo> partitionFields) {
- super(id, name, fields, fieldRelationShips, filters, sinkParallelism,
properties);
+ super(id, name, fields, fieldRelationShips, filters, filterStrategy,
sinkParallelism, properties);
Review Comment:
recommand every load node,every extract node have a builder mode, so every
time we add filed in 'LoadNode' or 'ExtractNode',We can avoid modifying the
call site of the constructor call.
Better open an issue to follow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
