Greedyu commented on code in PR #4113:
URL: https://github.com/apache/incubator-inlong/pull/4113#discussion_r874724236
##########
inlong-agent/agent-plugins/pom.xml:
##########
@@ -69,6 +69,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka-clients</artifactId>
Review Comment:
Because the debezium-embedded package calls kafka client 2.4.1, but the
Utils.isBlank method is connect-runtime 3.0.0. There is a problem with this
online logic, it is a bug
##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/reader/BinlogReader.java:
##########
@@ -41,38 +33,54 @@
import org.apache.inlong.agent.plugin.Message;
import org.apache.inlong.agent.plugin.Reader;
import org.apache.inlong.agent.plugin.sources.snapshot.BinlogSnapshotBase;
+import org.apache.inlong.agent.plugin.utils.InLongDatabaseHistory;
+import org.apache.inlong.agent.plugin.utils.InLongOffsetBackingStore;
import org.apache.inlong.agent.pojo.DebeziumFormat;
+import org.apache.inlong.agent.pojo.DebeziumOffset;
import org.apache.inlong.agent.utils.AgentUtils;
+import org.apache.inlong.agent.utils.DebeziumOffsetSerializer;
import org.apache.inlong.common.reporpter.ConfigLogTypeEnum;
import org.apache.inlong.common.reporpter.StreamConfigLogMetric;
import org.apache.kafka.connect.storage.FileOffsetBackingStore;
import org.slf4j.Logger;
-
import org.slf4j.LoggerFactory;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.LinkedBlockingQueue;
+
+import static
org.apache.inlong.agent.constant.CommonConstants.DEFAULT_MAP_CAPACITY;
+import static org.apache.inlong.agent.constant.CommonConstants.PROXY_KEY_DATA;
+
public class BinlogReader implements Reader {
private static final Logger LOGGER =
LoggerFactory.getLogger(BinlogReader.class);
- private static final String COMPONENT_NAME = "BinlogReader";
- private static final String JOB_DATABASE_USER = "job.binlogJob.user";
- private static final String JOB_DATABASE_PASSWORD =
"job.binlogJob.password";
- private static final String JOB_DATABASE_HOSTNAME =
"job.binlogJob.hostname";
- private static final String JOB_TABLE_WHITELIST =
"job.binlogJob.tableWhiteList";
- private static final String JOB_DATABASE_WHITELIST =
"job.binlogJob.databaseWhiteList";
+ public static final String COMPONENT_NAME = "BinlogReader";
+ public static final String JOB_DATABASE_USER = "job.binlogJob.user";
+ public static final String JOB_DATABASE_PASSWORD =
"job.binlogJob.password";
+ public static final String JOB_DATABASE_HOSTNAME =
"job.binlogJob.hostname";
+ public static final String JOB_TABLE_WHITELIST =
"job.binlogJob.tableWhiteList";
+ public static final String JOB_DATABASE_WHITELIST =
"job.binlogJob.databaseWhiteList";
- private static final String JOB_DATABASE_OFFSETS = "job.binlogJob.offsets";
- private static final String JOB_DATABASE_OFFSET_FILENAME =
"job.binlogJob.offset.filename";
+ public static final String JOB_DATABASE_OFFSETS = "job.binlogJob.offsets";
+ public static final String JOB_DATABASE_OFFSET_SPECIFIC_OFFSET_FILE =
"job.binlogJob.offset.specificOffsetFile";
+ public static final String JOB_DATABASE_OFFSET_SPECIFIC_OFFSET_POS =
"job.binlogJob.offset.specificOffsetPos";
- private static final String JOB_DATABASE_SERVER_TIME_ZONE =
"job.binlogJob.serverTimezone";
- private static final String JOB_DATABASE_STORE_OFFSET_INTERVAL_MS =
"job.binlogJob.offset.intervalMs";
+ public static final String JOB_DATABASE_SERVER_TIME_ZONE =
"job.binlogJob.serverTimezone";
Review Comment:
unit test use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
