healchow commented on code in PR #4211: URL: https://github.com/apache/incubator-inlong/pull/4211#discussion_r875959496
########## inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/hbase/HbaseSinkDTO.java: ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.common.pojo.sink.hbase; + +import com.fasterxml.jackson.databind.DeserializationFeature; +import com.fasterxml.jackson.databind.ObjectMapper; +import io.swagger.annotations.ApiModelProperty; +import lombok.AllArgsConstructor; +import lombok.Builder; +import lombok.Data; +import lombok.NoArgsConstructor; +import org.apache.inlong.manager.common.enums.ErrorCodeEnum; +import org.apache.inlong.manager.common.exceptions.BusinessException; + +import javax.validation.constraints.NotNull; +import java.util.Map; + +/** + * Hbase sink info + */ +@Data +@Builder +@NoArgsConstructor +@AllArgsConstructor +public class HbaseSinkDTO { + + private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper(); + + @ApiModelProperty("Target table name") + private String tableName; + + @ApiModelProperty("Namespace") + private String nameSpace; Review Comment: Please change to `namespace`, thanks. ########## inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/sink/HbaseSink.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.client.api.sink; + +import io.swagger.annotations.ApiModel; +import io.swagger.annotations.ApiModelProperty; +import lombok.AllArgsConstructor; +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.NoArgsConstructor; +import org.apache.inlong.manager.common.enums.DataFormat; +import org.apache.inlong.manager.common.enums.SinkType; +import org.apache.inlong.manager.common.pojo.stream.SinkField; +import org.apache.inlong.manager.common.pojo.stream.StreamSink; + +import java.util.List; + +/** + * Hbase sink. + */ +@Data +@EqualsAndHashCode(callSuper = true) +@NoArgsConstructor +@AllArgsConstructor +@ApiModel("Hbase sink configuration") +public class HbaseSink extends StreamSink { + + @ApiModelProperty(value = "Sink type", required = true) + private SinkType sinkType = SinkType.HBASE; + + @ApiModelProperty("Target table name") + private String tableName; + + @ApiModelProperty("Namespace") + private String nameSpace; + + @ApiModelProperty("Row key") + private String rowKey; + + @ApiModelProperty("Zookeeper quorm") + private String zookeeperQuorum; + + @ApiModelProperty("Sink buffer flush maxsize") + private String sinkBufferFlushMaxSize; + + @ApiModelProperty("Zookeeper znode parent") + private String zookeeperZnodeParent; + + @ApiModelProperty("Sink buffer flush max rows") + private String sinkBufferFlushMaxRows; + + @ApiModelProperty("Sink buffer flush interval") + private String sinkBufferFlushInterval; + + @ApiModelProperty("Create table or not") + private boolean needCreated; + + @ApiModelProperty("Field definitions for hbase") + private List<SinkField> sinkFields; + + @ApiModelProperty("Data format type for stream sink") + private DataFormat dataFormat; Review Comment: Did this filed needed for HBase sink? ########## inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/sink/HbaseSink.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.client.api.sink; + +import io.swagger.annotations.ApiModel; +import io.swagger.annotations.ApiModelProperty; +import lombok.AllArgsConstructor; +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.NoArgsConstructor; +import org.apache.inlong.manager.common.enums.DataFormat; +import org.apache.inlong.manager.common.enums.SinkType; +import org.apache.inlong.manager.common.pojo.stream.SinkField; +import org.apache.inlong.manager.common.pojo.stream.StreamSink; + +import java.util.List; + +/** + * Hbase sink. + */ +@Data +@EqualsAndHashCode(callSuper = true) +@NoArgsConstructor +@AllArgsConstructor +@ApiModel("Hbase sink configuration") +public class HbaseSink extends StreamSink { + + @ApiModelProperty(value = "Sink type", required = true) + private SinkType sinkType = SinkType.HBASE; + + @ApiModelProperty("Target table name") + private String tableName; + + @ApiModelProperty("Namespace") + private String nameSpace; Review Comment: Please change to `namespace`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
