ciscozhou commented on code in PR #4409:
URL: https://github.com/apache/incubator-inlong/pull/4409#discussion_r885115871
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/iceberg/IcebergSinkDTO.java:
##########
@@ -58,7 +59,7 @@ public class IcebergSinkDTO {
private String dataPath;
@ApiModelProperty("File format, support: Parquet, Orc, Avro")
- private String fileFormat;
+ private FileFormat fileFormat;
Review Comment:
If the type of `fileFormat` changed to `Enum`, the `getFromJson()` method
may be lost `fileFormat` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
