healchow commented on code in PR #4553:
URL: https://github.com/apache/incubator-inlong/pull/4553#discussion_r891140114
##########
inlong-manager/manager-web/sql/apache_inlong_manager.sql:
##########
@@ -54,7 +54,8 @@ CREATE TABLE IF NOT EXISTS `inlong_group`
`create_time` timestamp NULL DEFAULT CURRENT_TIMESTAMP
COMMENT 'Create time',
`modify_time` timestamp NULL DEFAULT CURRENT_TIMESTAMP ON
UPDATE CURRENT_TIMESTAMP COMMENT 'Modify time',
PRIMARY KEY (`id`),
- UNIQUE KEY `unique_inlong_group` (`inlong_group_id`, `is_deleted`)
+ UNIQUE KEY `unique_inlong_group` (`inlong_group_id`, `is_deleted`),
+ INDEX condition_idx (`status`, `is_deleted`, `modify_time`)
Review Comment:
Do we really need to put the modify_time field into the index?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
