healchow commented on code in PR #4562:
URL: https://github.com/apache/incubator-inlong/pull/4562#discussion_r893170303
##########
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/send/SenderChannel.java:
##########
@@ -17,26 +17,43 @@
package org.apache.inlong.audit.send;
+import io.netty.bootstrap.Bootstrap;
+import io.netty.channel.ChannelFuture;
+import io.netty.channel.ChannelOption;
+import io.netty.channel.EventLoopGroup;
+import io.netty.util.concurrent.DefaultThreadFactory;
+import org.apache.inlong.audit.util.EventLoopUtil;
import org.apache.inlong.audit.util.IpPort;
import io.netty.channel.Channel;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import java.util.concurrent.Semaphore;
+import java.util.concurrent.ThreadFactory;
public class SenderChannel {
+ private static final Logger logger =
LoggerFactory.getLogger(SenderChannel.class);
Review Comment:
Please change the static final variable to the UPPER_CAMEL_CASE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
