pocozh commented on code in PR #4536:
URL: https://github.com/apache/incubator-inlong/pull/4536#discussion_r894431683
##########
inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/HeartbeatManager.java:
##########
@@ -138,8 +139,9 @@ private Runnable heartBeatReportThread() {
int heartbeatInterval =
conf.getInt(AGENT_HEARTBEAT_INTERVAL,
DEFAULT_AGENT_HEARTBEAT_INTERVAL);
TimeUnit.SECONDS.sleep(heartbeatInterval);
- } catch (Exception ex) {
+ } catch (Throwable ex) {
LOGGER.error("error caught", ex);
Review Comment:
> There is also log processing in the threadThrowableHandler method. Can the
log output in the catch later be placed in it?
There may be some other error messages, such as 'LOGGER.error("error while
init sender for group id", ex)'. Moving it into threadThrowableHandler method
does not reflect some key information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
