healchow commented on code in PR #4651:
URL: https://github.com/apache/incubator-inlong/pull/4651#discussion_r895320005
##########
inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkOperation.java:
##########
@@ -139,8 +160,14 @@ public void genPath(FlinkInfo flinkInfo, String dataflow)
throws Exception {
flinkInfo.setLocalJarPath(jarPath);
log.info("get sort jar path success, path: {}", jarPath);
- String pluginPath = startPath + SORT_PLUGIN;
- List<String> connectorPaths = FlinkUtils.listFiles(pluginPath,
getConnectorJarPattern(flinkInfo), -1);
+ String connectorDir = getConnectorDir(startPath);
+ List<String> connectorPaths = FlinkUtils.listFiles(connectorDir,
getConnectorJarPattern(flinkInfo), -1);
+ if (CollectionUtils.isEmpty(connectorPaths)) {
+ String message = String.format("no sort connectors found in %s",
connectorDir);
+ log.error(message);
+ throw new Exception(message);
Review Comment:
Maybe throw a RuntimeException is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
