[GitHub] [inlong] leosanqing commented on a diff in pull request #4757: [INLONG-4745][Manager] Support list dataproxy nodes by extTag

Thu, 23 Jun 2022 04:50:24 -0700 


leosanqing commented on code in PR #4757:
URL: https://github.com/apache/inlong/pull/4757#discussion_r904924060


##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/openapi/DataProxyController.java:
##########
@@ -52,15 +54,9 @@ public class DataProxyController {
      * GET is used for quick lookup of IP lists (e.g. via browser requests).
      */
     @RequestMapping(value = "/dataproxy/getIpList", method = 
{RequestMethod.GET, RequestMethod.POST})

Review Comment:
   please ensure this request method. It should be one of get or post。if it's a 
get request, can not use @Requestbody. I think it may be get method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to