healchow commented on code in PR #4804:
URL: https://github.com/apache/inlong/pull/4804#discussion_r908538674


##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/openapi/DataProxyController.java:
##########
@@ -65,7 +65,7 @@ public Response<DataProxyConfig> getConfig(
             @RequestParam(required = true) String clusterName) {
         DataProxyConfig config = clusterService.getDataProxyConfig(clusterTag, 
clusterName);
         if (CollectionUtils.isEmpty(config.getMqClusterList()) || 
CollectionUtils.isEmpty(config.getTopicList())) {
-            return Response.fail("failed to get mq clusters or topics");
+            return Response.fail("Failed to get mq clusters or topics, make 
sure register mq to manager successfully");

Review Comment:
   It seems not necessary to change this, because the topic list also may be 
empty.
   So, check whether the MQ clusters are empty in the DataProxy is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to