gong commented on code in PR #4800:
URL: https://github.com/apache/inlong/pull/4800#discussion_r909288463
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongClusterController.java:
##########
@@ -47,14 +50,53 @@
* Inlong cluster controller
*/
@RestController
-@RequestMapping("/cluster")
@Api(tags = "Inlong-Cluster-API")
public class InlongClusterController {
@Autowired
private InlongClusterService clusterService;
- @PostMapping(value = "/save")
+ @PostMapping(value = "/cluster/tag/save")
+ @ApiOperation(value = "Save cluster tag")
+ @OperationLog(operation = OperationType.CREATE)
+ @RequiresRoles(value = UserRoleCode.ADMIN)
+ public Response<Integer> saveTag(@RequestBody ClusterTagRequest request) {
+ String currentUser = LoginUserUtils.getLoginUserDetail().getUsername();
+ return Response.success(clusterService.saveTag(request, currentUser));
+ }
+
+ @GetMapping(value = "/cluster/tag/get/{id}")
+ @ApiOperation(value = "Get cluster tag by id")
+ @ApiImplicitParam(name = "id", value = "Cluster ID", dataTypeClass =
Integer.class, required = true)
+ public Response<ClusterTagResponse> getTag(@PathVariable Integer id) {
+ return Response.success(clusterService.getTag(id));
+ }
+
+ @PostMapping(value = "/cluster/tag/list")
+ @ApiOperation(value = "List cluster tags")
+ public Response<PageInfo<ClusterTagResponse>> listTag(@RequestBody
ClusterTagPageRequest request) {
+
request.setCurrentUser(LoginUserUtils.getLoginUserDetail().getUsername());
+ return Response.success(clusterService.listTag(request));
+ }
+
+ @PostMapping(value = "/cluster/tag/update")
+ @OperationLog(operation = OperationType.UPDATE)
+ @ApiOperation(value = "Update cluster tag")
+ public Response<Boolean> updateTag(@RequestBody ClusterTagRequest request)
{
Review Comment:
lost `@Valid`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
