healchow commented on code in PR #4832:
URL: https://github.com/apache/inlong/pull/4832#discussion_r911704985
##########
inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkOperation.java:
##########
@@ -161,15 +174,46 @@ public void genPath(FlinkInfo flinkInfo, String dataflow)
throws Exception {
flinkInfo.setLocalJarPath(jarPath);
log.info("get sort jar path success, path: {}", jarPath);
+ List<String> nodeTypes = new ArrayList<>();
+ if (StringUtils.isNotEmpty(dataflow)) {
+ JsonNode streams =
JsonUtils.parseTree(dataflow).get(InlongConstants.STREAMS);
+ for (int i = 0; i < streams.size(); i++) {
+ JsonNode relations =
streams.get(i).get(InlongConstants.RELATIONS);
+ for (int j = 0; j < relations.size(); j++) {
+ String inputNames =
OBJECT_MAPPER.convertValue(relations.get(j).get(InlongConstants.INPUTS),
Review Comment:
Why name them `inputNames` and `outputNames`? Should remove the last char
`s`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
