healchow commented on code in PR #4917:
URL: https://github.com/apache/inlong/pull/4917#discussion_r917204138
##########
inlong-manager/manager-dao/src/main/resources/mappers/StreamSinkEntityMapper.xml:
##########
@@ -480,5 +480,15 @@
is_deleted = 0
</where>
</select>
+ <select id="selectAllStreams"
+
resultType="org.apache.inlong.manager.common.pojo.sortstandalone.SortSourceStreamInfo">
+ select inlong_cluster_name as sortClusterName,
+ sort_task_name,
+ inlong_group_id as groupId
+ from stream_sink
+ <where>
Review Comment:
If there are no more where sentences, can be simply as:
```xml
where is_deleted = 0
```
At the same time, **this result set may be very large**. Are you sure you
need to find all the results at once?
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/SortClusterServiceImpl.java:
##########
@@ -50,6 +51,7 @@
* Use to cache the sort cluster config and reduce the number of query to
database.
*/
@Service
+@Lazy
Review Comment:
Is it possible to put `@Lazy` on the line above `@Service` or `@Autowired`?
- This makes the code format look better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
